-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the luminosity and bin mask options for FKs to the python interface #273
Conversation
This looks good to me. It would be perfect if you could also add a small test. |
I'm working on fixing the signature. Of course, you could drop the last commit and merge, but I believe to be valuable to avoid some overhead (whenever possible). |
As you wish, since you are at it please add also the test that @cschwan asked for. |
3f2fbf9
to
9bace31
Compare
Thanks @alecandido As a note for the future, we should add maybe a test that does the entire |
It seems to work. I've just copied it from the grid.